-
Notifications
You must be signed in to change notification settings - Fork 365
Add contributing guidelines to CONTRIBUTING.md #2845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Added contributing guidelines for the WordPress Playground project, detailing how to contribute, guidelines to follow, and links to relevant resources.
Updated links and standards for pull requests and coding guidelines.
Removed redundant line breaks and merged sentences for clarity.
|
Do you think this PR will be reviewed? @brandonpayton |
|
@theaminuli, thanks for submitting the PR, but I would like to know the impact of it. I have commented on the issue. I would like to understand how relevant this file is, once we have that information available in the README and https://wordpress.github.io/wordpress-playground/ I want to avoid content duplication because it can impact the maintenance of the docs. |
fellyph
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @theaminuli thanks for submitting the PR, I have a few suggestions
| - Documentation – see the [documentation section](https://wordpress.github.io/wordpress-playground/docs/contributing/documentation). | ||
| - Triage – see the [triage section](https://wordpress.github.io/wordpress-playground/contributing/#triaging-issues). | ||
| - Contributions to translations – see the [translations section](https://wordpress.github.io/wordpress-playground/contributing/translations). | ||
| - Reporting bugs – open an [issue](https://github.com/WordPress/wordpress-playground/issues/new) in the repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can suggest the template issues:
| - Reporting bugs – open an [issue](https://github.com/WordPress/wordpress-playground/issues/new) in the repository. | |
| - Reporting bugs – open an [issue](https://github.com/WordPress/wordpress-playground/issues/new/choose) in the repository. |
|
|
||
| Here's a few quickstart guides to get you started: | ||
|
|
||
| - Code contributions – see the [developer section](https://wordpress.github.io/wordpress-playground/docs/contributing/code). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can be consistent with the links:
| - Code contributions – see the [developer section](https://wordpress.github.io/wordpress-playground/docs/contributing/code). | |
| - Code contributions – see the [developer section](https://wordpress.github.io/wordpress-playground/contributing/code/). |
| Here's a few quickstart guides to get you started: | ||
|
|
||
| - Code contributions – see the [developer section](https://wordpress.github.io/wordpress-playground/docs/contributing/code). | ||
| - Documentation – see the [documentation section](https://wordpress.github.io/wordpress-playground/docs/contributing/documentation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Documentation – see the [documentation section](https://wordpress.github.io/wordpress-playground/docs/contributing/documentation). | |
| - Documentation – see the [documentation section](https://wordpress.github.io/wordpress-playground/contributing/documentation). |
|
|
||
| WordPress Playground is an open-source project and welcomes all contributors from code to design, and from documentation to triage. If the feature you need is missing, you are more than welcome to start a discussion, open an issue, and even propose a Pull Request to implement it. | ||
|
|
||
| Here's a few quickstart guides to get you started: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Here's a few quickstart guides to get you started: | |
| Here are a few quickstart guides to get you started: |
| - Contributions to translations – see the [translations section](https://wordpress.github.io/wordpress-playground/contributing/translations). | ||
| - Reporting bugs – open an [issue](https://github.com/WordPress/wordpress-playground/issues/new) in the repository. | ||
| - Ideas, designs or anything else – open a [GitHub discussion](https://github.com/WordPress/wordpress-playground/discussions) and let's talk! | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add a mention to the Playground Slack Channel:
- Connect with the Playground team at [`#playground` channel on WordPress Slack](https://wordpress.slack.com/archives/C04EWKGDJ0K)
| - Before submitting a pull request, review the [repository management and pull request best practices](https://wordpress.github.io/wordpress-playground/contributing/code), and follow the WordPress Playground coding and accessibility standards. | ||
| - WordPress Coding Standards [Coding Standards](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/) | ||
| - **Maintain compatibility:** If your changes affect shared functions, modules, or APIs, ensure they don’t break existing Playground environments or integrations. | ||
| - You maintain copyright over your contributions.By submitting a pull request, you agree to release your code under [Playground’s License](/LICENSE.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - You maintain copyright over your contributions.By submitting a pull request, you agree to release your code under [Playground’s License](/LICENSE.md). | |
| - You maintain copyright over your contributions. By submitting a pull request, you agree to release your code under [Playground’s License](/LICENSE.md). |
| ## 🧭 Guidelines | ||
| - As with all WordPress projects, we’re committed to a **welcoming, inclusive, and respectful environment** for everyone. Please follow our [Code of Conduct](https://make.wordpress.org/handbook/community-code-of-conduct/). | ||
| - Before submitting a pull request, review the [repository management and pull request best practices](https://wordpress.github.io/wordpress-playground/contributing/code), and follow the WordPress Playground coding and accessibility standards. | ||
| - WordPress Coding Standards [Coding Standards](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - WordPress Coding Standards [Coding Standards](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/) | |
| - [WordPress Coding Standards](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/) |
What:
Created a new CONTRIBUTING.md file in the project root.
Why:
The repository didn’t have contribution guidelines.
This file helps new contributors understand how to set up the project, follow coding standards, and submit pull requests properly.
File Created:
CONTRIBUTING.md — includes:
Fixed: #2844